Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't upload to S3 if local cache exists #76

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Don't upload to S3 if local cache exists #76

merged 3 commits into from
Sep 24, 2024

Conversation

calvinbui
Copy link
Contributor

Fixes #66

Additionally:

  • dont set TAR_FILE var a second time
  • don't delete the cache tarfile when finished.
    • i dont know if this is expected to save disk space?
    • deleting it would would defeat the purpose of using save-cache
    • tarball or rsync don't delete the cache either

@calvinbui calvinbui changed the title Fix/dont upload on cache hit Don't upload to S3 if local cache exists Sep 24, 2024
@gencer gencer merged commit 64143c0 into nienbo:master Sep 24, 2024
1 check passed
@calvinbui calvinbui mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't upload to S3 on local cache hit
2 participants
@calvinbui @gencer