Update references and schema #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nietras
reviewed
Sep 15, 2024
* MacOS tests require it * Allows compiler to emit more optimized code
|
Overall lgtm and thanks! Would you mind bumping version to 0.3.0 (I think)? |
|
There seems to be some weird build errors (lack of API) on linux, macos but not windows 🤔 Test project only. |
|
I think that might have fixed it. |
|
please don't remove global.json, fix version in that to latest dotnet 8 sdk switch latestMajor to latestPatch |
ds5678
force-pushed
the
update-references-and-schema
branch
from
4e4e034 to
3aabad1
Compare
|
Good now? |
|
Anything else I need to do? |
|
@ds5678 no I think it should be good, I'll try to look it over tomorrow on my PC and merge if all ok, then publish new version on nuget. :) |
nietras
reviewed
Sep 17, 2024
singular tfm
|
@ds5678 merged, thank you. Next is update on nuget which may not be until tomorrow though. |
|
should be up on nuget now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.