Wrong UART speed for MWII protocol

[pmarkiewicz]

Wrong UART speed for MWII protocol, it's 57600 instead of 115200.
In case of MWII AUTOBAUD shouldn't be used.

Looks like case is not related to current hardware (OZE32 board, Naze32 + minimOSD integrated).

Latest version, 944, build locally.
Bug is replicable in all versions.

I have ready pull request with fix.

[night-ghost]

can be MWII protocol on other speed than 115200?

[pmarkiewicz]

never seen other speed, you can of course compile firmware with different speed. THis is from anciet times of MultiiWiiCopter on ATMega. Also here is hardcoded https://github.com/ShikOfTheRa/scarab-osd/blob/131ffd412383cd1d9d747b74d5f177d628481504/MW_OSD/Def.h And in iNav there is: serialConfig->portConfigs[i].msp_baudrateIndex = BAUD_115200 For whatever reason autodetection doesn't work in case of MSP (I didn't investigated this part) regards 2018-04-26 13:15 GMT+01:00 night-ghost <notifications@github.com>:

…

can be MWII protocol on other speed than 115200? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#217 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdfI_bLv3C-QwyhL_HG-nNNowS54-wnks5tsbpIgaJpZM4Su9vs> .

[pmarkiewicz]

but iNavFlight/inav#3127 2018-04-26 13:25 GMT+01:00 Piotr Markiewicz <piotr.markiewicz@gmail.com>:

…

never seen other speed, you can of course compile firmware with different speed. THis is from anciet times of MultiiWiiCopter on ATMega. Also here is hardcoded https://github.com/ShikOfTheRa/scarab-osd/blob/ 131ffd412383cd1d9d747b74d5f177d628481504/MW_OSD/Def.h And in iNav there is: serialConfig->portConfigs[i].msp_baudrateIndex = BAUD_115200 For whatever reason autodetection doesn't work in case of MSP (I didn't investigated this part) regards 2018-04-26 13:15 GMT+01:00 night-ghost ***@***.***>: > can be MWII protocol on other speed than 115200? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#217 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAdfI_bLv3C-QwyhL_HG-nNNowS54-wnks5tsbpIgaJpZM4Su9vs> > . >

[night-ghost]

so it is too early to drop autobaud

could you turn on DEBUG and do a screenscast/video what is going on OSD?

[pmarkiewicz]

probably, let's wait for answer. 2018-04-26 13:34 GMT+01:00 night-ghost <notifications@github.com>:

…

so it is too early to drop autobaud — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#217 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdfIz1rpTT0KUX_SjAFg9Mw7SCD7POEks5tsb67gaJpZM4Su9vs> .

[pmarkiewicz]

We got answer from iNav team and still have no idea why it's not 115. My problem is that baud autodetection code didn't work for me that why I disabled one and left hardcoded value. I think we can keep this hardcoded unless someone will raise an issue related to that. 2018-04-26 13:41 GMT+01:00 Piotr Markiewicz <piotr.markiewicz@gmail.com>:

…

probably, let's wait for answer. 2018-04-26 13:34 GMT+01:00 night-ghost ***@***.***>: > so it is too early to drop autobaud > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#217 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAdfIz1rpTT0KUX_SjAFg9Mw7SCD7POEks5tsb67gaJpZM4Su9vs> > . >

[night-ghost]

the answer was a really cool :)

autobaud was highly tested and works just fine for MAVlink, so it seems very strange to me. But as you wish, it will be turned off for MWII in next version, so please remove this part from PR

[pmarkiewicz]

anothere answer clarifies a bit. I think you can reject PR and I will create new one just for roll/pitch and voltage 2018-04-27 13:33 GMT+01:00 night-ghost <notifications@github.com>:

…

the answer was a really cool :) autobaud was highly tested and works just fine for MAVlink, so it seems very strange to me. But as you wish, it will be turned off for MWII in next version, so please remove this part from PR — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#217 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdfI2M7O3kLvr-WzuDmYsND2cVsRlzbks5tsxApgaJpZM4Su9vs> .

[BondarenkoA]

i tested last commit. MWII uart speed still 57600. Because #define AUTOBAUD 0 in the func.h:getData(). When it commented, MWII stay worked, but uart speed does not dysplayed on the diagnostic screen.

[night-ghost]

Thanks, that "define" was a bug, fixed. UARD speed shown only if autobaud is turned on. If you can build binaries please uncomment "define DEBUG", turn on autobaud and see to measured pulse time.