Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all branches] - ResistanceLowersTarget does not work #152

Closed
mountrcg opened this issue May 5, 2024 · 1 comment
Closed

[all branches] - ResistanceLowersTarget does not work #152

mountrcg opened this issue May 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mountrcg
Copy link
Contributor

mountrcg commented May 5, 2024

Describe the bug
due to this line the oref functionality resistance_lowers_target does not work as it is always false

To Reproduce
Steps to reproduce the behavior:

  1. activate that setting in preferences
  2. watch for an autosens >1
  3. see if target in popup will be lower when from from profile
  4. See that is the same, which would be an error and target is not adjusted due to the setting in oref

Expected behavior
target need to be lower than profile target

Solution
case resistanceLowersTarget = "resistance_lowers_target" in preferences.swift (see above)

@mountrcg mountrcg added the bug Something isn't working label May 5, 2024
@mountrcg mountrcg changed the title ResistanceLowersTarget does not work [all branches] - ResistanceLowersTarget does not work May 5, 2024
@MikePlante1
Copy link
Contributor

Thanks for reporting this and pointing to the solution. Fix proposed in #155 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants