fix resistanceLowersTarget #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Robert <comps@diprobe.com>
|
DynamicISF is off, no temp targets or profile overrides are being used: Test before applying this PR: Test after applying this PR: |
|
@mountrcg , does this look ok? |
bjornoleh
approved these changes
May 10, 2024
dnzxy
approved these changes
May 11, 2024
mountrcg
requested review from
bjornoleh
and removed request for
mountrcg and
bjornoleh
|
Sry screwed up the reviews here. |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduced the error with current
devwhere target does not change even when resistance is detected andResistance Lowers Targetis toggled on.After applying this PR, target was lowered as expected.
Addresses #152