Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "G6" -> "G6 / ONE" and "G7" -> "G7 / ONE+" #379

Closed
LiroyvH opened this issue Aug 11, 2024 · 2 comments · Fixed by #424
Closed

Rename "G6" -> "G6 / ONE" and "G7" -> "G7 / ONE+" #379

LiroyvH opened this issue Aug 11, 2024 · 2 comments · Fixed by #424
Assignees
@MikePlante1
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request in-progress

Comments

@LiroyvH
Copy link
Contributor

LiroyvH commented Aug 11, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Trio in the CGM selection only declares support for G6 and G7, whilst ONE and ONE+ also work with them (in that order) respectively.

Describe the solution you'd like

Change CGM Selection / configuration options, menu's, etc. to read "Dexcom G6 / ONE" and "Dexcom G7 / ONE+" instead of "Dexcom G6" or "Dexcom G7" respectively.

Describe alternatives you've considered

Leave it as it is and let users figure it out themselves, just to f- with 'em.

Additional context

Primarily relevant in Settings -> CGM and its subsettings/submenus. (And localization strings)

Technical Details

There are no additional dependencies other than the official Dexcom-apps of the respective sensor/transmitter.

User Impact

Users will understand which option to choose if they wish to use ONE or ONE+, whereas they currently may believe they're unsupported or don't know what to select.
@LiroyvH LiroyvH added enhancement New feature or request needs-triage labels Aug 11, 2024
@Sjoerd-Bo3 Sjoerd-Bo3 added this to Trio Aug 11, 2024
@MikePlante1 MikePlante1 self-assigned this Aug 11, 2024
@LiroyvH LiroyvH changed the title Rename "G6" -> "G6 / ONE" and "G7" -> "G7 & ONE+" Rename "G6" -> "G6 / ONE" and "G7" -> "G7 / ONE+" Aug 11, 2024
This was referenced Aug 11, 2024
Closed
Closed
@dnzxy dnzxy added dependencies Pull requests that update a dependency file in-progress and removed needs-triage labels Aug 18, 2024
@Sjoerd-Bo3
Copy link
Contributor

@LiroyvH I think #424 should fix this

@bjornoleh
Copy link
Contributor

@LiroyvH I think #424 should fix this

Confirmed!

@bjornoleh bjornoleh linked a pull request Oct 8, 2024 that will close this issue
Update Submodules - Fixes Xcode 16 slow build plus other updates #424
Merged
@github-project-automation github-project-automation bot moved this to Done in Trio Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikePlante1 MikePlante1

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request in-progress
Projects
Trio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Submodules - Fixes Xcode 16 slow build plus other updates loopandlearn/Trio
5 participants
@Sjoerd-Bo3 @LiroyvH @dnzxy @bjornoleh @MikePlante1