-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Submodules - Fixes Xcode 16 slow build plus other updates #424
Update Submodules - Fixes Xcode 16 slow build plus other updates #424
Conversation
Notes about most recent commit:
|
These updates to the SHA for the LoopKit submodules aligns with the version for these submodules just released in Loop 3.4.3. Since last comment, I added commits so code matches the LoopKit/LibreTransmitter:main branch and LoopKit/LoopKit:dev branch and SHA match the values found in loopandlearn/*:trio branch. This latest update for the LoopKit submodule is improvement in visibility for CheckmarkListItems, especially important for dark mode with iOS 18 devices. Graphic shows screen from previous code on left and updated code on the right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds to sim, can confirm G6+ and G7+ text is updated, and otherwise involves very few changes to code.
No uncommitted changes after building.
Merging with 2 approvals. |
Main Goal
The primary item fixed in this PR is Issue #423.
Added updates
In addition, pick up other submodule fixes that are in the loopandlearn/submodule:trio branches but not yet added to Nightscout/Trio:dev workspace.
Information for reviewers.
pxbproj
file) there are two other files modified that are only used by Looppxbproj
file, another modification was brought in to prevent notification when not enabledSummary of submodules changed with this PR: