Introduce proper guardrails for bolus entries (pump bolus and external insulin)

[bjornoleh]

There is currently no guardrail / max limit for logging of external insulin ("Bolus without actually bolusing"). This can cause issues with dISF, since even after deleting an erroneous entry, the bolus dose will still linger in the TDD storage in CoreData, and there is no way to reset this except by deleting the app.

Suggestion: Introduce max limit for external bolus. Possibly based on the pump setting for max bolus. @

Please note that some might set a low max bolus for the pump to reduce the risk of large doses causing "tunneling". Some also combine this strategy by taking the bulk of the meal bolus by pen/syringe. In this case, limiting external bolus to the max pump bolus will be inconvenient. Possibly 3 - 10 x max pump bolus would be appropriate? Otherwise, we need a separate setting for max external bolus.

This has been discussed at length in the iAPS project, but I can't find the discussion right now.

[bjornoleh]

This was fixed in some recent PR.

But I notice now that the max bolus limit is imposed when bolus = max bolus. I would expect to be allowed to bolus up to the max limit. @MikePlante1 ?

We might want to include the localised units to the max bolus amount as well.

[MikePlante1]

Thanks, @bjornoleh. I'll take another look at this. It looks like that warning is improperly displayed when amount==max, but it will still let you bolus until amount>max

[bjornoleh]

Thanks, yes I notice now that I can bolus the full Max bolus amount, despite the warning. If above, the enact bolus button is greyed out.

[bjornoleh]

Fixed in #100 and #172 🥳