Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Max Bolus exceeded label #172

Merged
merged 1 commit into from
May 11, 2024
Merged

update Max Bolus exceeded label #172

merged 1 commit into from
May 11, 2024

Conversation

MikePlante1
Copy link
Contributor

no longer shows when amount equals max, and adds unit after max bolus amount.

@MikePlante1
update 'Max Bolus exceeded' label
ddb4936 
no longer shows when amount equals max, and adds unit after max bolus amount.
bjornoleh
bjornoleh approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works as it should, including the localised insulin unit. This is ready to be merged 🚀

dnzxy
dnzxy approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging with 2 approvals.

@dnzxy dnzxy merged commit 47078a4 into nightscout:dev May 11, 2024
@MikePlante1 MikePlante1 deleted the max_bolus branch May 11, 2024 03:01
@bjornoleh bjornoleh mentioned this pull request May 11, 2024
Closed
This was referenced May 11, 2024
Merged
Merged
@MikePlante1 MikePlante1 mentioned this pull request May 19, 2024
Closed
@MikePlante1 MikePlante1 mentioned this pull request Jun 16, 2024
Closed
4 tasks
@MikePlante1 MikePlante1 changed the title update 'Max Bolus exceeded' label update Max Bolus exceeded label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornoleh bjornoleh bjornoleh approved these changes

@dnzxy dnzxy dnzxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikePlante1 @dnzxy @bjornoleh