[alpha-issue] - TidePool - Looks like all boluses are labeled as "automated". This highlighted bolus was manual.

[avouspierre]

          Looks like all boluses are labeled as "automated". This highlighted bolus was manual.

(This test was done via the alpha branch, not specifically this PR, btw)

Originally posted by @MikePlante1 in #30 (comment)

[avouspierre]

@MikePlante1 I think oiaps doesn't store the origin (SMB or manual bolus) of each dose injected. Probably requires to improve the data model of DoseEntry.

[bjornoleh]

@dnzxy , I believe the distinction between manual bolus and SMB was introduced after v2.3.3, perhaps you were involved in that?

[dnzxy]

Yes. See #93, @BrianWieder is working in bringing that over. I implemented it for iAPS, Brian ported it over (thanks bud!).

It sets a flag, so you should be able to differentiate between SMBs, manual doses and external doses @avouspierre

[bjornoleh]

Yes. See #93, @BrianWieder is working in bringing that over. I implemented it for iAPS, Brian ported it over (thanks bud!).

It sets a flag, so you should be able to differentiate between SMBs, manual doses and external doses @avouspierre

Thanks! I do see theisExternalInsulin flag being set, but not yet isSMB, as far as I can tell. But perhaps that is work in progress (or I missed it) 😊

[dnzxy]

I think Brian will bring that in judging by #93 description.

Follow-up PRs will add the rest of the features for #47

It was part of Artificial-Pancreas/iAPS#267 and later automatic was removed from History view and replaced with SMB 😊

[BrianWieder]

Yes, going to work on bringing over isSMB and displaying it within the history sheet later today.

[BrianWieder]

Created the isSMB flag in #101.

[bjornoleh]

I believe this issue is resolved now? Which PR fixed this?

[avouspierre]

@bjornoleh the correction was done with the PR #104

[bjornoleh]

@bjornoleh the correction was done with the PR #104

Hi, PR #104 was actually closed and not merged into dev. Perhaps it was replaced with another PR, or already merged in alpha? I could however not find anythingh in Trio dev when searching fro isSMB in the TidepoolManager.swift file:
https://github.com/nightscout/Trio/blob/dev/FreeAPS/Sources/Services/Network/TidepoolManager.swift

Could you please check if the fix for automated vs manual bolus in Tidepool is indeed included in current dev?

[github-actions]

hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!

[bjornoleh]

I think this is resolved, but maybe not by the PR that was referenced above.

[marionbarker]

This is not resolved. I just tested it. All boluses are labeled automatic in the Tidepool website display:

• smb
• manual bolus
• external bolus

In Loop the distinction is made that manual and external (non-pump) both show up as manual (no label shown and a lighter blue) and automatic shows up as automatic (label says automatic and darker blue).

[github-actions]

hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!

[marionbarker]

This issue is still present in main branch.

[dnzxy]

Addressed for TCD / Trio 1.0.0 dev.