Add external insulin #104
Closed
Add external insulin #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dnzxy <d.c.cengiz@googlemail.com>
Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
Update tidepool to add external insulin
Co-Authored-By: Deniz Cengiz <48965855+dnzxy@users.noreply.github.com>
|
resolve issue #77 with isSMB attribute available. |
NightscoutTreatment should be agnostic, so moving the init extension into PumpHistoryStorage allows for better sepearation of concerns.
Update tidepool after removing externalInsulin event type by @BrianWieder
|
Is this superceded by PR #140? |
|
@avouspierre Sorry, I accidentally closed this when I deleted the alpha branch. I reopened it and changed it to target dev now instead. |
MikePlante1
changed the title
|
I believe this PR was superceded by PR #140. |
|
@marionbarker Whenever a branch is deleted, GitHub automatically closes all PRs targeting that branch. |
|
Can this be closed as #140 introduces all its contents and supercedes it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes the #93 and #80 to add external insulin in the interface.
The PR includes #101
The PR updates tidepool to add / delete external insulin and iSMB logic