Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PreferencesEditorStateModel.swift #143

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

tmhastings
Copy link
Contributor

Correct pop up text for 'tddAdjBasal' from 7 days to 10 days

Correct pop up text for 'tddAdjBasal' from 7 days to 10 days
@bjornoleh
Copy link
Contributor

I’m pretty sure it’s in fact 14 days :-)

@tmhastings
Copy link
Contributor Author

There was quite a bit of research by @polscm32, @dnzxy, @MikePlante1, and myself to determine that it is actually 10, contrary to the minimized text and other references elsewhere.

@bjornoleh
Copy link
Contributor

bjornoleh commented May 2, 2024

How so? This should be defined in determine-basal, no?

Edit: this should be the correct definition:

https://github.com/nightscout/open-iaps-oref/blob/487bcbba594b267070a1d5892c709251026c48e8/lib/determine-basal/determine-basal.js#L582

@flyingpie101
Copy link

weird, in the other server, i think this was just being discussed.
image

@tmhastings
Copy link
Contributor Author

We determined that it's the TDD from oref2_variables that is passed to self.determineBasal. And in oref2_variables, TDD is determined this way:
10 days

@bjornoleh
Copy link
Contributor

Ouch, alright, I stand corrected. I haven’t kept up with the “oref2” changes apparently.

@dnzxy
Copy link
Contributor

dnzxy commented May 2, 2024

It also doesn’t help, that the variable is called average14 and actually only covers 10 days of data…

@MikePlante1 MikePlante1 changed the base branch from alpha to dev May 2, 2024 19:52
@MikePlante1
Copy link
Contributor

Changed base to dev, now that alpha has been merged into dev.

@MikePlante1 MikePlante1 merged commit 96dd917 into dev May 2, 2024
@MikePlante1 MikePlante1 deleted the tmhastings-tddAdjBasal branch May 2, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants