modify text to Open-iAPS #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added another change of the string "FAX" to "Open-iAPS" in *.swift files. (Note iAPS and FAX are both found in *.strings files). I tested this code change (pr 148) with the watch complication.
|
MikePlante1
approved these changes
May 5, 2024
bjornoleh
approved these changes
May 5, 2024
Merged
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently only fixes the instances of iAPS to Open-iAPS in swift files.
See Issue #136 which indicates another change is required for a plist file and for *.strings files.
Please advise on additional changes desired, or this change alone can be merged with other updates in future PR.
I tested that all the strings (with exception of strings after "Import Settings from Nightscout" now show Open-iAPS instead of iAPS.
The "Import Settings from Nightscout" fails for me, so I am not shown the updated message to "please verify all of your new settings thoroughly" that should now refer to Open-iAPS with this code modification.