-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Defaults (high, rulerMarks, maxCarbs, sensitivityRaisesTarget) #156
Conversation
Looks good. Should we also take a Quick Look at the defaults inPreferences (OpenAPS settings)? I believe there are some things that could be off. Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF. Good to get this done now that setting are being reset by similar changes. |
Looks like OpenAPS defaults that to ON as well, though: https://github.com/openaps/oref0/blob/88cf032aa74ff25f69464a7d9cd601ee3940c0b3/lib/profile/index.js#L24 |
Looks like OpenAPS also defaults UAM to ON, though. 🤔 |
high (for stats & main chart line): 145 -> 180 rulerMarks: false -> true maxCarbs: 1000 -> 250
b6885b0
to
0c581c0
Compare
Thanks for checking. What’s the verdict on that setting in our app? How does it fit if enabling dynamic ISF? My impression from looking at others discussing it is that it causes more problems than it solves, but I have always turned it off, so can’t really tell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Will merge this now with two approvals.
Adding for transparency that this was discussed more extensively on Discord. |
Change maxCarbs default to 250, to match #156
high
(for stats & main chart line):145
->180
rulerMarks
(the high/low lines on the main chart):false
->true
maxCarbs
:1000
->250
sensitivityRaisesTarget
:true
->false