Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Defaults (high, rulerMarks, maxCarbs, sensitivityRaisesTarget) #156

Merged
merged 5 commits into from
May 11, 2024

Conversation

MikePlante1
Copy link
Contributor

@MikePlante1 MikePlante1 commented May 6, 2024

high (for stats & main chart line): 145 -> 180
rulerMarks (the high/low lines on the main chart): false -> true
maxCarbs: 1000 -> 250
sensitivityRaisesTarget: true -> false

@bjornoleh
Copy link
Contributor

Looks good. Should we also take a Quick Look at the defaults inPreferences (OpenAPS settings)? I believe there are some things that could be off. Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF.

Good to get this done now that setting are being reset by similar changes.

@MikePlante1
Copy link
Contributor Author

Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF.

Looks like OpenAPS defaults that to ON as well, though: https://github.com/openaps/oref0/blob/88cf032aa74ff25f69464a7d9cd601ee3940c0b3/lib/profile/index.js#L24

@MikePlante1
Copy link
Contributor Author

Looks like OpenAPS also defaults UAM to ON, though. 🤔

high (for stats & main chart line): 145 -> 180
rulerMarks: false -> true
maxCarbs: 1000 -> 250
@MikePlante1 MikePlante1 changed the title Update Defaults (units, high, rulerMarks, maxCarbs) Update Defaults (high, rulerMarks, maxCarbs) May 6, 2024
@bjornoleh
Copy link
Contributor

Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF.

Looks like OpenAPS defaults that to ON as well, though: https://github.com/openaps/oref0/blob/88cf032aa74ff25f69464a7d9cd601ee3940c0b3/lib/profile/index.js#L24

Thanks for checking. What’s the verdict on that setting in our app? How does it fit if enabling dynamic ISF? My impression from looking at others discussing it is that it causes more problems than it solves, but I have always turned it off, so can’t really tell.

@bjornoleh bjornoleh self-requested a review May 7, 2024 13:32
@MikePlante1 MikePlante1 changed the title Update Defaults (high, rulerMarks, maxCarbs) Update Defaults (high, rulerMarks, maxCarbs, sensitivityRaisesTarget) May 11, 2024
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge this now with two approvals.

@bjornoleh bjornoleh merged commit b851a5e into nightscout:dev May 11, 2024
@MikePlante1 MikePlante1 deleted the update_defaults branch May 11, 2024 16:46
@MikePlante1
Copy link
Contributor Author

Adding for transparency that this was discussed more extensively on Discord.

bjornoleh added a commit that referenced this pull request May 12, 2024
Change maxCarbs default to 250, to match #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants