Override refactoring and additional functionnalities #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
fix when preset has no id
|
|
replaced by #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes a large refactoring of the swift part of override/profile functions :
This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
TODO : Changes the shortcuts after merging with PR #144 and add watch for overrides.