“Add pump” button when pump has not been configured

[avouspierre]

The PR adds a “pump” icon and “add pump” label in the header of the main view.
The tap gesture open the view to select a pump.

Link with #171 to review.

[bjornoleh]

Works as expected during brief testing by adding and removing the sim or Dash pump driver on a non.looping phone. Thanks!

I did not inspect the code.

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[bjornoleh]

Do you plan on resolving the remaining 2 sonarcloud issues? If so I'll wait with reviewing :-)

[avouspierre]

Do you plan on resolving the remaining 2 sonarcloud issues? If so I'll wait with reviewing :-)

That's the problem with a "minor" fix required to review again. I don't think to resolve the 2 sonarcloud issues because all the (old) code is based on the double or triple closures in swiftUI. Not sure this rule is very useful and improve the maintenance of the code.

[marionbarker]

Code review - some of this is beyond my skill level, but all looks reasonable.

Testing:

Configuration:

• SE phone, iOS 17.5, Trio dev branch (commit 56a3f87), no pump attached (graphic on left)
• git apply trio-pr-184.patch` and rebuild (graphic on right)

[bjornoleh]

Still works as expected by testing on the phone. Merging after two approving reviews.