allows to open CGM setting view when tapping on the homescreen #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c59813e)
|
I am quite used to opening the CGM when tapping BG value, specifically to open the Xdrip4iOS app in our case. I understand that this opens CGM settings instead? I am unsure if the improvement in access to CGM settings is needed? It does make sense compared to the pump setup, but that might be needed more often than CGM settings? Also, there are some Tidepool changes, not sure if they belong in this PR ? |
|
I did a mistake in the commit with pushing a mock file of TidePool. I will revert and propose a new PR. You can close it this. |
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
Sjoerd-Bo3
pushed a commit
to Sjoerd-Bo3/Trio
that referenced
this pull request
Aug 3, 2024
Fix various issues. Fix issues nightscout#21 , nightscout#26 and nightscout#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c59813e)