Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dismiss keyboard when clicking note for meal entries #215

Merged
merged 1 commit into from
May 18, 2024

Conversation

avouspierre
Copy link
Contributor

a icon is available to dismiss the keyboard even no content.

Fix #211

a icon is available to dismiss the keyboard.
Copy link
Contributor

@JeremyStorring JeremyStorring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix, looks great to me :)

Copy link

@DreyCon-Raphael DreyCon-Raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks legit

Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying this change, the following screen is shown after touching Note.

  • On the left, the dismiss keyboard icon is shown
  • On the right, the view after touching the dismiss keyboard icon
  • Does dismissing the keyboard differ from tapping return on the keyboard?

trio-pr-215

Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Merging with several approving reviews.

@bjornoleh bjornoleh merged commit 4242168 into nightscout:dev May 18, 2024
1 check passed
@MikePlante1 MikePlante1 mentioned this pull request May 20, 2024
@MikePlante1 MikePlante1 changed the title fix #211 issue dismiss keyboard when clicking note for meal entries May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to dismiss keyboard when clicking note for meal entries
5 participants