-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DanaKit] Progress update 02-06-2024 #263
Conversation
Disables `Save and continue` button once pressed by utilizing new `mealSaved` flag. Renames `saved` to `noteSaved`.
Ensure meal is only saved once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the Typo's (vv1), LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- iPhone SE running 17.5.1, Trio dev (commit 14c7643)
- connected to rPI DASH simulator
- Built feat/dana (commit 13dfdec)
- The pod behaved nominally.
- disconnect rPi pod
- connect rPi dana-simulator
- did a bolus but then ran into simulator issues (the rPi never finishes the bolus)
Assume the issues I am seeing are due to the rPi simulator.
Is there anyone with a real Dana pump who can test this?
Tried again and was able to sync to new instance of the rPi dana-simulator and got a green loop.
From previous experience with the simulator, I doubt it will stay green.
I updated to most recent commit and configured to the new version of the dana-simulator. What works
What does not workI can't figure out how to delete Dana once it is selected. I think when I delete the Dana pump for the Dana menu - it should indicate no pump on main screen.
Next try to delete Dana pump and control C out of simulator. @avouspierre Can you help on the deleting pump part? |
Merging with two approvals |
A long overdue update for the DanaKit project. This PR contains (but not limited to) the following changes:
And a sync with dev :)