Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DanaKit] Progress update 02-06-2024 #263

Merged
merged 6 commits into from
Jun 8, 2024

Conversation

bastiaanv
Copy link
Contributor

@bastiaanv bastiaanv commented Jun 2, 2024

A long overdue update for the DanaKit project. This PR contains (but not limited to) the following changes:

  • fix for Loop cycle hangs
  • Lower limit of time difference (was 1 minute, but caused double insulin entries)
  • Rename all the hardcoded Loop to the dynamic appName (thanks @marionbarker!)
  • Added error messages for failed bolus (daily limit violation or bolus timeout error, i.e.)
  • Improved static basal steps (since a Dana pump supports basal steps of 0.01U/hr)
  • Optimize connection logic/sync (some data will only be synced during the sync function instead of at every connection)

And a sync with dev :)

MikePlante1 and others added 4 commits May 29, 2024 21:47
Disables `Save and continue` button once pressed by utilizing new `mealSaved` flag.
Renames `saved` to `noteSaved`.
Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the Typo's (vv1), LGTM!

DanaKit Show resolved Hide resolved
Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • iPhone SE running 17.5.1, Trio dev (commit 14c7643)
  • connected to rPI DASH simulator
  • Built feat/dana (commit 13dfdec)
  • The pod behaved nominally.
  • disconnect rPi pod
  • connect rPi dana-simulator
  • did a bolus but then ran into simulator issues (the rPi never finishes the bolus)

Assume the issues I am seeing are due to the rPi simulator.
Is there anyone with a real Dana pump who can test this?

Tried again and was able to sync to new instance of the rPi dana-simulator and got a green loop.
From previous experience with the simulator, I doubt it will stay green.

@marionbarker
Copy link
Contributor

I updated to most recent commit and configured to the new version of the dana-simulator.

What works

  • I can now bolus more than once (simulator update)
  • I can get a green loop whether glucose is rising or failling

What does not work

I can't figure out how to delete Dana once it is selected.

I think when I delete the Dana pump for the Dana menu - it should indicate no pump on main screen.
I can't figure out how to switch away from Dana once it has been selected.

  • main screen shows !! No insulin
    • tapping on that icon takes you to choose which dana pump you want
  • Settings -> pump also takes you to choose which dana pump you want
  • You can scan and it finds it (because rPi is still connected).

Next try to delete Dana pump and control C out of simulator.
Quit the Trio app and rebuild.
It still only allows user to reconnect to Dana pump.
Restarting the rPi simulator allows Trio to connect.

@avouspierre Can you help on the deleting pump part?

@bjornoleh
Copy link
Contributor

Merging with two approvals

@bjornoleh bjornoleh merged commit d8d5d2d into nightscout:feat/dana Jun 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants