Add an option to confirm boluses faster on Apple Watch #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePlante1
requested review from
AndreasStokholm,
Sjoerd-Bo3,
dnzxy and
bjornoleh
bjornoleh
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Functionality confirmed by building to Xcode simulator for iPhone 15 and S7 watch simulator.
The default was "off", and enabling the Confirm bolus faster feature did exactly that.
The code looks reasonable after a quick glance.
Given that this has also been used for a good while in iAPS, I'd say this is LGTM (unless someone objects to the implementation of such a feature).
dnzxy
approved these changes
Jun 7, 2024
Sjoerd-Bo3
approved these changes
Jun 8, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to reduce the amount you need to spin the crown on an Apple Watch to confirm a bolus.
⚙️>
Watch>Confirm Bolus FasterHas been in iAPS-dev since 2024-02-09: Artificial-Pancreas/iAPS#508