Rework DecimalTextField Struct and Toolbar

[polscm32]

• fix clear button not working as expected
• make cursor right adjusted when tapping in the Textfield
• fix constraint error appearing when tapping into Textfield

Tested by me and @AndreasStokholm

[kskandis]

Did you also want to add @bjornoleh's review request to right adjust the Note TextField, add Clear and Done buttons, and hide its Keyboard icon?

[polscm32]

Sure, can do that. Forgot that because we got rid of this field in our UI rework😅

[Sjoerd-Bo3]

Going to test this next

[marionbarker]

Tested - works in these screens (very nice):

• carb/fat/protein/notes entry
• enact bolus
• enact temp target
• Nightscout (nit but the Port should not have a thousands place separator, shows us as 8,080 for US English)
• Notifications
• Statistics and Home View
• Preferences
• Pump Settings
• Meal Settings
• These use pickers so n/a: Basal Settings, Insulin Sensitivities, Carb Ratios, Target Glucose)

[marionbarker]

Only item I saw was minor: formatting of Port in Nightscout Screen.

[Sjoerd-Bo3]

Only item I saw was minor: formatting of Port in Nightscout Screen.

Also the only Item I observed, THe changes for the rest are great! Works as it should have been.

@polscm32 Could you adjust the Nightscout port field?

[Sjoerd-Bo3]

Except for the nightscout port LGTM

[polscm32]

Will have a look today!

[polscm32]

Should be fixed. Pls test xD

[Sjoerd-Bo3]

Code looks good! And the change works! Tnx!

[dnzxy]

LGTM, sane and surgical change. Thanks!

[Sjoerd-Bo3]

Merging with 2 approvals and Previous from Marion