direct user where to flip Upload Glucose toggle #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only display if the selected CGM disables the toggle in Nightscout > Upload.
MikePlante1
requested review from
dnzxy,
bjornoleh,
aug0211,
AndreasStokholm,
Sjoerd-Bo3 and
t1dude
as code owners
|
Should this be a request to I confirmed that this works as indicated, but it is still really confusing. It's still really confusing, but I think this is a good-enough work-around for RC1. |
marionbarker
previously approved these changes
Jun 30, 2024
Sjoerd-Bo3
approved these changes
Jul 2, 2024
marionbarker
approved these changes
Jul 2, 2024
Merged
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Jul 20, 2024
direct user where to flip Upload Glucose toggle
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
This was referenced Oct 18, 2024
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
Upload Glucosetoggle is disabled when using a plugin for the cgm source (Dexcom or LibreTransmitter), display text to direct the user to where they can flip the toggle. If they aren't using a plugin for their cgm source, then this text won't be displayed.Addresses issue #199