Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemfile update #340

Merged
merged 1 commit into from
Jul 2, 2024
Merged

gemfile update #340

merged 1 commit into from
Jul 2, 2024

Conversation

mountrcg
Copy link
Contributor

@mountrcg mountrcg commented Jul 1, 2024

From the conversation @dnzxy and @marionbarker had on Discord. I updated the gemfile, as the error also occured in one of my repos. This gemfile fixed the error.

@marionbarker
Copy link
Contributor

Summary

Successful test

Details

  • I tested this by adding this version of Gemfile.lock to iAPS dev.
  • The build action was successful with this file.

Background

  • Previously, Gemfile.lock was removed completely from iAPS dev and main because an older version prevented the fastlane portion of the build action from succeeding.
  • I previously tested by trying to build iAPS main with GitHub action using the commit before the Gemfile.lock was removed and demonstrated that it failed Failure log

@marionbarker marionbarker self-requested a review July 1, 2024 15:27
@bjornoleh
Copy link
Contributor

@mountrcg , what was your errors, were they the same as in Marion’s failure log above? Were they consistent or only for some build attempts?

Anything that differs from Trio in GitHub actions or fastlane related code on your end?

@mountrcg
Copy link
Contributor Author

mountrcg commented Jul 2, 2024

@bjornoleh it was error 34 as well - no I don't think so - have just the same as iAPS in that repo fastlane wise. Was reported in iAPS channel on autoisf discord.

Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Builds in Fastlane

@Sjoerd-Bo3 Sjoerd-Bo3 merged commit 232ff0d into nightscout:dev Jul 2, 2024
@MikePlante1 MikePlante1 mentioned this pull request Jul 16, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants