-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload SAGE to NS for Dexcom #355
Conversation
StatusEverything I could test seemed fine. Code reviewCode review looks good - although I wonder if an enum plus case statements is more in keeping with the style of the app.
Test
|
It looks like the enum for which cgm is being used was just changed to
Is your Trio app connected to a Nightscout account to see if it updates SAGE properly for your G7? One whose SAGE was either out of date or non-existent? I can give you credentials for a spare NS if you need. |
Is starting a new CGM required in order to test this, can we test this with an existing/already started CGM? I suppose we may be able to just forget/remove the existing G7 and re-add in Trio after applying this commit? |
(Edit: existing G7 is fine) Is SAGE currently out-of-date in your NS? If yes, apply this PR and after receiving 1 or 2 readings from G7, check NS to see if SAGE is now updated properly. |
Even the code introduced specific lib in main code, currently no other simple solution to collect sage information. Probably could be a very good solution to have a generic API / method in loop submodules to retrieve this info and avoid specific code. |
Not currently out of date because I use a shortcut to set it. It sounds like this can be tested with an exciting sensor though, just by clearing the previous sensor date from the backend in NS. Thanks, will take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tested with G7 in vivo
- Success
- Deleted previous sensor change date from Nightscout
- Confirmed latest sensor age from Nightscout was gone
- Deployed this code over my live instance of Trio
- After 1 loop, nothing updated
- After 2nd loop, the SAGE updated correctly
- I now also see the sensor insertion date in Nightscout history, noting the sensor bluetooth ID which is nice
Old manual sensor start entry:
Delete the old entry:
Confirm the old entry is gone:
Viola, the new G7 start entry automatically appears:
Merging with 3 approvals. Thank you @MikePlante1 |
Upload SAGE to NS for Dexcom
Address Issue #269 when using Dexcom G5, G6 (ONE), or G7 (ONE+) as a CGM source. Note this does not address using xDrip4iOS as a cgm source.
It expands on (and slightly refactors) the LibreTransmitter fix in #112 . Please reference the comments on that PR about adding the LibreTransmitter library (this PR adds the CGMBLEKit and G7SensorKit libraries).
The only testing I've done for this PR is with my in-vivo phone.
- Testing still needs to be done using G7
Before building this PR, my phone was at the tip of dev: 9672da2
Files > Trio > Monitor
and there was no filecgm-state.json
Treatments
and checked ☑️Event Type: CGM Sensor Start
CGM Sensor Start
are 2024-04-01 and 2024-03-22 but those were from when I used xDrip4iOS and directly uploaded glucose to NS from xDrip4iOS instead of Trio/iAPS.After receiving my first reading from G6 after building this PR to my phone:
cgm-state.json
now exists inFiles > Trio > Monitor