Fix manual glucose entry for mmol/L

[MikePlante1]

• Prevents mmol/L entry from being forced into having 1 decimal place
• Fixes typo that swapped high/low limits from mg/dL and mmol/L
• Round down for entry instead of to nearest

Addresses Issue #339

Before this PR:

prePR_.mov

After this PR:

postPR_.mov

[marionbarker]

Status

LGTM to fix the mmol/L Glucose entry problem
Then we can resolve whether there is a better method for fixing this with more consistent units handling

Code Review

• code changes looks appropriate
• Can someone check localization?
  • I tried different languages and did not see the decimal/thousands place delimiters I expected
  • If confirmed, that should be a separate issue.

Test

Confirm problem

• build with dev, 8303f0a
• confirm cannot enter mmol/L values > 9.9 on glucose screen

Confirm fix

• apply patch from PR 356
• confirm can now enter mmol/L values up to 40 mmol/L on glucose screen
• no error message is give when > 40 mmol/L is attempted, but the save button is inactive so that's ok for now
• It is a little disconcerting to enter 40.0 or 10.0 and have it modify the display to 40 or 10 respectively
  • The display on the log includes the single decimal point for mmol/L
• Switch to mg/dL - confirm min/max range is now 14 mg/dL to 720 mg/dL
• Switch to mmol/L to test the low range (log changes to 0.8 mmol)
  • confirm min/max range is 0.8 to 40.0 mmol/L

[MikePlante1]

• Can someone check localization?

  • I tried different languages and did not see the decimal/thousands place delimiters I expected
  • If confirmed, that should be a separate issue.

You have to change the Region of the phone, not the Language.

• It is a little disconcerting to enter 40.0 or 10.0 and have it modify the display to 40 or 10 respectively

  • The display on the log includes the single decimal point for mmol/L

I agree that it's not great, but unfortunately having it auto-format to a single decimal place is what messed up being able to enter double digits. I played around with it a bunch to make it so minimumFractionDigits defaults to 0, is set to 1 when the user types a decimal point, and is reset to 0 if the decimal point is deleted... but couldn't get it to work right.

[dnzxy]

LGTM