Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser build sync and alive behavior #374

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Aug 4, 2024

This PR is in response to Trio Issue #373. In addition to fixing the main build for GitHub actions, this also brings in these other changes:

  • update macos up to version 14
  • explicitly set Xcode version to 15.4
  • modify # Patch Fastlane Match to not print tables to not print user information in the clear
    • this was identified as a privacy issue in LoopWorkspace (happened in macos-14, not seen previously when using macos-13)

This PR uses changes to LoopWorkspace PR 164 following release of Loop version 3.4.0.

The timing is such that the main branch must exist and this PR be applied at the same time.

Status:

  • The Browser Build for Trio will not run using this PR until the main branch actually exists

Test

  • In order to test, I modified build_trio.yml in the test fork to use the dev branch for both alive-main and alive-dev
  • The build action was successful with this modification.

Code Review:

I compared the *.yml files found in LoopWorkspace (main, aka 3.4.1)
These 3 are identical:

  • validate_secrets.yml
  • add_identifiers.yml
  • create_certs.yml

These files differ only in references to LoopWorkspace vs Trio and LoopWorkspace embeds a section on customizations that it not found in Trio:

  • build_loop.yml vs build_trio.yml

@marionbarker
Copy link
Contributor Author

In addition to the files listed above, comparison was also made between LoopWorkspace 3.4.1 for these files:

  • Gemfile
  • Gemfile.lock
  • fastlane/Fastfile

The first two files are identical. The Fastfile has the suitable changes between Loop and Trio along with some whitespace changes. The Trio version configures and uses the BUNDLE_ID which simplifies some lines.

@marionbarker
Copy link
Contributor Author

Status

Success
Caveat - might still have some users with alive branch failures - if so, they just need to delete any branch starting with alive and then run again.

Testing

This can be tested now that there is a main branch at nightscout/Trio

  • Before - it would fail because SHA_MAIN was null

Test Overview:

  • Use loopdocs-tester GitHub username.
  • Need to have the branch name be called dev for the test.
  • Do the merge of patch from this PR into dev for just loopdocs-tester.

Test dev branch with PR 374 applied

  • Success: build Trio (dev) with this patch (so one commit ahead of nightscout:dev)
    • alive-dev and alive-main created

Test main branch

  • add new branch using nightscout:main
  • this is identical to dev branch but without the PR applied
    • there is no alive branch
  • Success: build Trio (main)
    • alive branch created

Copy link
Contributor

@MikePlante1 MikePlante1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this PR in and successfully built, which correctly created two new branches: alive-main and alive-dev.

@MikePlante1 MikePlante1 merged commit b6b9b86 into nightscout:dev Aug 16, 2024
1 check passed
@MikePlante1 MikePlante1 mentioned this pull request Aug 17, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Sep 11, 2024
Fix browser build sync and alive behavior
@marionbarker marionbarker deleted the fix-sync-alive branch October 3, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants