-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browser build sync and alive behavior #374
Conversation
… LoopWorkspace PR 164
In addition to the files listed above, comparison was also made between LoopWorkspace 3.4.1 for these files:
The first two files are identical. The Fastfile has the suitable changes between Loop and Trio along with some whitespace changes. The Trio version configures and uses the BUNDLE_ID which simplifies some lines. |
StatusSuccess TestingThis can be tested now that there is a
Test Overview:
Test dev branch with PR 374 applied
Test main branch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled this PR in and successfully built, which correctly created two new branches: alive-main
and alive-dev
.
Fix browser build sync and alive behavior
This PR is in response to Trio Issue #373. In addition to fixing the main build for GitHub actions, this also brings in these other changes:
# Patch Fastlane Match to not print tables
to not print user information in the clearThis PR uses changes to LoopWorkspace PR 164 following release of Loop version 3.4.0.
The timing is such that the main branch must exist and this PR be applied at the same time.
Status:
Test
Code Review:
I compared the *.yml files found in LoopWorkspace (main, aka 3.4.1)
These 3 are identical:
These files differ only in references to LoopWorkspace vs Trio and LoopWorkspace embeds a section on customizations that it not found in Trio: