Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URL scheme for Open-iAPS #41

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Update URL scheme for Open-iAPS #41

merged 1 commit into from
Apr 1, 2024

Conversation

bjornoleh
Copy link
Contributor

  • Config.xconfig: APP_URL_SCHEME = Open-iAPS
  • remove hardcoded "freeaps-x", leaving $(APP_URL_SCHEME)
  • CGMType.swift: libreTransmitter: URL(string: "Open-iAPS://libre-transmitter"
  • AlertEntry.swift: static let manual = "Open-iAPS"
  • CarbsEntry.swift: static let manual = "Open-iAPS"
  • NightscoutTreatment.swift: static let local = "Open-iAPS"
  • Sources/Models/TempTarget.swift: static let manual = "Open-iAPS"
  • NightscoutAPI.swift: var enteredBy = "Open-iAPS", var notes = "Open-iAPS connected"
  • GarminManager.swift: connectIQ?.initialize(withUrlScheme: "Open-iAPS", uiOverrideDelegate: self)

@bjornoleh
Update URL scheme for Open-iAPS
360cec3 
- Config.xconfig: APP_URL_SCHEME = Open-iAPS
- remove hardcoded "freeaps-x", leaving $(APP_URL_SCHEME)
- CGMType.swift: libreTransmitter: URL(string: "Open-iAPS://libre-transmitter"
- AlertEntry.swift: static let manual = "Open-iAPS"
- CarbsEntry.swift: static let manual = "Open-iAPS"
- NightscoutTreatment.swift: static let local = "Open-iAPS"
- Sources/Models/TempTarget.swift: static let manual = "Open-iAPS"
- NightscoutAPI.swift: var enteredBy = "Open-iAPS", var notes = "Open-iAPS connected"
- GarminManager.swift: connectIQ?.initialize(withUrlScheme: "Open-iAPS", uiOverrideDelegate: self)
@bjornoleh
Copy link
Contributor Author

bjornoleh commented Mar 31, 2024 •
edited
Loading

I have tested that NS entries for bolus, carbs and temp targets now have the correct "Entered by".

Example for TT:
image

Also the message when connecting to NS is verified:

image

Edit:
I also tested that opening the app works on the phone. Tested using a Scriptable widget, and set i to open Open-iAPS when tappin the widget by setting URL = Open-iAPS://

@bjornoleh
Copy link
Contributor Author

Changing the base branch to feat-bundleid-versionnumber, as testing gets inconvenient now that the bundle ID is being changed in #31, and the contents of this PR is closely related to #31 .

@bjornoleh bjornoleh changed the base branch from dev to feat-bundleid-versionnumber April 1, 2024 21:09
@bjornoleh bjornoleh changed the base branch from feat-bundleid-versionnumber to dev April 1, 2024 21:17
@bjornoleh bjornoleh changed the base branch from dev to feat-bundleid-versionnumber April 1, 2024 21:17
@bjornoleh bjornoleh removed the request for review from avouspierre April 1, 2024 21:18
@bjornoleh
Copy link
Contributor Author

Merging this into feat-bundleid-versionnumber

@bjornoleh bjornoleh merged commit 89d45e8 into feat-bundleid-versionnumber Apr 1, 2024
@bjornoleh bjornoleh mentioned this pull request Apr 1, 2024
Merged
@bjornoleh bjornoleh deleted the urlScheme branch April 1, 2024 21:25
@bjornoleh bjornoleh mentioned this pull request Apr 4, 2024
Merged
@MikePlante1 MikePlante1 mentioned this pull request Jun 16, 2024
Closed
4 tasks
Sjoerd-Bo3 pushed a commit to Sjoerd-Bo3/Trio that referenced this pull request Aug 12, 2024
@dnzxy
Merge pull request nightscout#41 from polscm32/fix-trend
29ae1e8 
fix trend in watch manager & notifications -> fix issue #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bjornoleh