Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/duration #1178

Merged
merged 14 commits into from
Oct 17, 2015
Merged

Wip/duration #1178

merged 14 commits into from
Oct 17, 2015

Conversation

MilosKozak
Copy link
Contributor

No description provided.

@MilosKozak
Copy link
Contributor Author

image
image

@codecov-io
Copy link

Current coverage is 84.37%

Merging #1178 into dev will decrease coverage by -0.26% as of 78fbf56

@@              dev   #1178   diff @@
=====================================
  Files          77      77       
  Stmts        5748    5933   +185
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          4865    5006   +141
  Partial         0       0       
- Missed        883     927    +44

Review entire Coverage Diff as of 78fbf56

Uncovered Suggestions

  1. +0.20% via .../js/profileeditor.js#324...335
  2. +0.19% via .../js/profileeditor.js#269...279
  3. +0.17% via .../report/js/report.js#262...271
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@MilosKozak
Copy link
Contributor Author

@jasoncalabrese your comments/improvements?

@jasoncalabrese
Copy link
Member

Not sure about turning off fields for the default 'BG Check' event type, I think lots of people don't bother with the event type. Would need to change the UI to the common types more visible.

For the visualization,I think we should try to make it a little lighter, maybe drop the outlines. Also think we should be careful about about introducing more colors and things before getting temp basal and combo boluses in.

@MilosKozak
Copy link
Contributor Author

That's one of the reason to add this, grandparents mostly didn't change eventType

@MilosKozak
Copy link
Contributor Author

With temp basals and combo boluses we'll need even more fields. Without hiding unneeded fields drawer becomes confusing

@jasoncalabrese
Copy link
Member

yeah, I see that issue too, maybe at first we only show the new fields for new types? A different UI would encourage better type selection.

jasoncalabrese
jasoncalabrese reviewed Oct 17, 2015
View reviewed changes
lib/plugins/basalprofile.js
$('#basals-switch').change(function switchChart (event) {
window.Nightscout.client.chart.basals.attr('display', $('#basals-switch').is(':checked') ? '' : 'none');
if (event) {
event.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a event.stopPropagation() here would stop the tooltip from showing on toggle?

@jasoncalabrese jasoncalabrese added this to the 0.8.2 milestone Oct 17, 2015
jasoncalabrese added a commit that referenced this pull request Oct 17, 2015
@jasoncalabrese
Merge pull request #1178 from MilosKozak/wip/duration
6ff37fd 
Wip/duration
@jasoncalabrese jasoncalabrese merged commit 6ff37fd into nightscout:dev Oct 17, 2015
@jasoncalabrese
Copy link
Member

huge step forward thanks @MilosKozak

This was referenced Apr 27, 2021
Open
Open
Open
@abaducu abaducu mentioned this pull request Oct 1, 2023
Open
@ratzzzster-dev ratzzzster-dev mentioned this pull request Oct 1, 2023
Open
@raghumovva raghumovva mentioned this pull request Oct 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2 (Funnel Cake)
Development

Successfully merging this pull request may close these issues.
4 participants
@MilosKozak @codecov-io @jasoncalabrese @scottleibrand