Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto ack alarms when going back into range or when the a cgm error corrects #329

Merged
merged 3 commits into from
Jan 11, 2015

Conversation

jasoncalabrese
Copy link
Member

This should remove some of the annoyance of alarms, no more returning home to alarms for a condition that was already corrected (but not ack'd)

@jasoncalabrese
Copy link
Member Author

I'd like to get this into the release since I think it's a big source of alarm annoyment, would like a review by @bewest and @rnpenguin

@bewest
Copy link
Member

bewest commented Jan 11, 2015

Looks like some useful clean up here! Thanks.

Is there a new feature that should be ENABLE'd here or is this a bug fix?
(This is to help establish design controls, code review, etc...).

@jasoncalabrese
Copy link
Member Author

I see this as a bug fix. Without this fix alarms will continue until ack'd even when the condition changes.

For example when a user is away from home they use the notifications on the dexcom receiver or the pebble to make corrections. In that case alarms from the cgm-remote-monitor are not ack'd or even seen. When they return home any devices running cgm-remote-monitor will still be alarming for a condition that has long since been corrected. This leads to distrust of the system and false panic.

I've run this for 2 days without issue, some others from the support team have also done some testing of this fix.

@bewest
Copy link
Member

bewest commented Jan 11, 2015

👍 please :shipit:

jasoncalabrese added a commit that referenced this pull request Jan 11, 2015
auto ack alarms when going back into range or when the a cgm error corrects
@jasoncalabrese jasoncalabrese merged commit 1aec240 into dev Jan 11, 2015
@jasoncalabrese jasoncalabrese deleted the wip/auto-acking branch January 11, 2015 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants