Change min_5m_carbimpact from 3 to 8 #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumil
added a commit
to rumil/cgm-remote-monitor
that referenced
this pull request
Nov 30, 2018
* upstream/autotune: (77 commits) Update history.js (nightscout#3562) Change min_5m_carbimpact from 3 to 8 (nightscout#3563) Use new id if received one is invalid. npm update / mongo fix / small fixes (nightscout#3413) update dutch language. reapply nightscout#3405 to dev update docs to reflect changes in alexa backend requiring SSL type selection english translation was ok, fixing extra space in dutch translation Change Reporting screen default to "newest on top" Fix "dispalyed" typo Revert removing forever (apologies; must have tested the the wrong branch in Heroku, leading me to think it's auto-injected if needed). de fix Removed git-rev due to unclear benefit. Removed unused dependencies. Italian Language (nightscout#3244) Add "Views" section (nightscout#3211) if no value, return 0 (nightscout#3332) Fix PUMP_WARN_ON_SUSPEND in README.md Fix Mongo connection string test Update Mongo Driver to 3.0 series and have it retry connecting to Mongo in case the socket goes down for much longer update russian (nightscout#3209) Add "Check for Updates" link (nightscout#3206) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the autotune branch used a
min_5m-carbimpactof 3 instead of 8 as oref0 does, leading to unrealistic carb absorption results and thus wrong autotune results. Changingmin_5m-carbimpactfrom 3 to 8 leads to Nightscout autotune providing results very similar to autotune running on a rig (still not perfectly identical for reasons I have not yet understood)PS: Do we need these codacy-bot entries? I find that they make some longer discussions completely unreadable.