upgrades, moment-locales-webpack-plugin integration, easier bundle-analyzer, dutch translations #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alyzer 1. webpack 4.16.0 gives problem with report test on Windows ``` Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info. Arguments: [0] _isAMomentObject: true, _isUTC: true, _useUTC: true, _l: undefined, _i: T00:00:00, _f: undefined, _strict: undefined, _locale: [object Object] Error at Function.createFromInputFallback (E:\Git\src\cgm-remote-monitor\tmp\js\bundle.js:1:5989) ``` 2. a lot of moment-locales are packacked with webpack. Limit to language that are availble in Nightscout 3. make it possible to use `npm run bundle-analyzer` so that webpack.config.js does not have to be changed
|
More info on 2. the moment-locals. Here's an overview of the bundle before the PR: And here is an overview of the bundle after this PR: |
|
Detailed view Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed it with an upgrade to 4.16.1
a lot of moment-locales are packaged with webpack. Limit to language that are available in Nightscout. Note that
dkis not available in moment.js. This decreasesjs/bundle.js from 1.86 MiB to 1.72 MiB.
make it possible to use
npm run bundle-analyzerso that webpack.config.js does not have to be changed in order to run the bundle-analyzeradd missing Dutch translations