feat: add Node 12 Active LTS support, drop Node 8 support (this PR also merges some wip/013alpha stuff) #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 2019-05-08
Update dev branch
(cherry picked from commit 62b830f)
(cherry picked from commit cf63611)
(cherry picked from commit 23a182b)
(cherry picked from commit 739b01e)
… profile support was added, the caching of value fetches broke, causing the calls to get profile data to be > 100x slower than before. Additionally, this changes the COB plugin to not calculate COB locally at all if a recent value is available from status uploads
Fix font size on axis labels
…onitor into d3-upgrade
…-monitor into wip/013alpha
(cherry picked from commit b07dbd2)
(cherry picked from commit 3e07c62)
…into 20191_0130_version
…te-monitor into 20191_0130_version
PieterGit
changed the title
|
@PieterGit can you pull out the changes you'd made here that are mergeable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress
We should limit the number of Node versions we support. In a few days Node 10 and Node 12 will both be Active LTS, so I think we should drop Node v8 support and make Node 12 LTS support available starting with Nightscout 0.13.x. In general this means we will (for now) only support Active LTS releases of Node.
Discussion: I propose that we use Node 12 for
0.13.x-devand we will release Nightscout 0.13.0 with with a preference for latest Node 10 LTS and also support Node 12 LTS. Starting from Nightscout 0.14.0 we can make Node 12 the default suggested version (and still remain Node 10 support for a while).@jpcunningh @sulkaharo agree?
TODO: