Correct APIv3 handling of multiple filter parameters for a single field #8252
+96
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the last filter parameter for a field would be applied. After this change, filter parameters for fields are aggregated instead of being replaced. Additional tests were added to both verify the new behavior as well as to verify other documented API functionality, such as the use of ISO8601 dates. This allows for range queries, ex: date$gt=1491719030000&date$lt=1491719930000
This was referenced Apr 17, 2024
|
The API version should probably be incremented after accepting this, or it could be added to this MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the last filter parameter for a field would be applied. After this change, filter parameters for fields are aggregated instead of being replaced.
This allows for range queries, ex: date$gt=1491719030000&date$lt=1491719930000
Additional tests were added to both verify the new behavior as well as to verify other documented API functionality, such as the use of ISO8601 dates.