Fix command args showing as '[object Object]' in reporter. (#4195)

nightwatchjs · May 5, 2024 · bfcc09a · bfcc09a
1 parent 2aac3ec
commit bfcc09a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/reporter/index.js b/lib/reporter/index.js
@@ -238,7 +238,17 @@ class Reporter extends SimplifiedReporter {
 
   static stringifyArgs(args) {
     if (Array.isArray(args)) {
-      return args.map((arg) => arg && arg.toString());
+      return args.map((arg) => {
+        let stringifiedArg;
+
+        try {
+          stringifiedArg = JSON.stringify(arg);
+        } catch {
+          stringifiedArg = arg && arg.toString();
+        }
+
+        return stringifiedArg;
+      });
     }
 
     return args;

diff --git a/test/src/runner/testReporter.js b/test/src/runner/testReporter.js
@@ -324,7 +324,7 @@ describe('testReporter', function() {
             assert.ok(Object.keys(command).includes('endTime'));
             assert.ok(Object.keys(command).includes('elapsedTime'));
             assert.ok(Object.keys(command).includes('result'));
-            assert.deepEqual(command.args, ['http://localhost']);
+            assert.deepEqual(command.args, ['"http://localhost"']);
             assert.strictEqual(command.status, 'pass');
           }
         },