Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disable process listener for programattic api #3800

Conversation

swrdfish
Copy link
Member

@swrdfish swrdfish commented Jul 11, 2023

Adds flag to disable process-listener while using programatic api.
Required when users want to have control over error reporting.

Usage

const clientWithoutListner = Nightwatch.createClient({
    timeout: 500,
    useAsync: false,
    output: false,
    silent: false,
    headless: true,
    output_folder: 'output',
    globals: {
        testGlobal: 'one'
    },
    disable_process_listener: true
})

@swrdfish swrdfish requested review from gravityvi and beatfactor July 11, 2023 06:42
@github-actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@gravityvi
Copy link
Member

Should we link the issue that this PR is trying to solve?

@swrdfish swrdfish linked an issue Jul 11, 2023 that may be closed by this pull request
@swrdfish
Copy link
Member Author

Created an issue and linked it.

@AutomatedTester AutomatedTester changed the title Feature/disable process listner for programattic api Feature/disable process listener for programattic api Jul 13, 2023
gravityvi
gravityvi approved these changes Jul 14, 2023
@beatfactor beatfactor merged commit 54e1e3e into nightwatchjs:main Jul 19, 2023
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
)

* disable programattic api for process listners

* refactor and add tests
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
)

* disable programattic api for process listners

* refactor and add tests
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
)

* disable programattic api for process listners

* refactor and add tests
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
)

* disable programattic api for process listners

* refactor and add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to disable process listener
3 participants