Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cucumber-runner): allow esm imports (#3805) #3806

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix(cucumber-runner): allow esm imports (#3805) #3806

merged 3 commits into from
Jul 18, 2023

Conversation

thermsdorff
Copy link
Contributor

@thermsdorff thermsdorff commented Jul 12, 2023 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Status

  • ✅ Type files updated!

@gravityvi
Copy link
Member

Hey @thermsdorff 👋, Thank you for fixing the issue. Could you add a test? Something like this:

nightwatch/test/src/runner/cucumber-integration/testCliArgs.js

Line 49 in ac1a1ff

it('Cucumber cli args', function(){

@thermsdorff
Copy link
Contributor Author

Hello @gravityvi !
Tests added and i also add possibility to enable esm through cli arguments.

@gravityvi
Copy link
Member

Thanks @thermsdorff

@AutomatedTester AutomatedTester merged commit 943dcfa into nightwatchjs:main Jul 18, 2023
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@thermsdorff @yashPratp983
fix(cucumber-runner): allow esm imports (nightwatchjs#3805) (nightwat…
93f5cd9 
…chjs#3806)

* fix(cucumber-runner): allow esm imports (nightwatchjs#3805)

* fix(cucumber-runner): add cli-arg 'enable-esm'

* test(cucumber-runner): add tests for enable esm options/cli arg
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@thermsdorff @yashPratp983
fix(cucumber-runner): allow esm imports (nightwatchjs#3805) (nightwat…
85c1b61 
…chjs#3806)

* fix(cucumber-runner): allow esm imports (nightwatchjs#3805)

* fix(cucumber-runner): add cli-arg 'enable-esm'

* test(cucumber-runner): add tests for enable esm options/cli arg
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@thermsdorff @yashPratp983
fix(cucumber-runner): allow esm imports (nightwatchjs#3805) (nightwat…
4edee7b 
…chjs#3806)

* fix(cucumber-runner): allow esm imports (nightwatchjs#3805)

* fix(cucumber-runner): add cli-arg 'enable-esm'

* test(cucumber-runner): add tests for enable esm options/cli arg
yashPratp983 pushed a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@thermsdorff @yashPratp983
fix(cucumber-runner): allow esm imports (nightwatchjs#3805) (nightwat…
9ba791d 
…chjs#3806)

* fix(cucumber-runner): allow esm imports (nightwatchjs#3805)

* fix(cucumber-runner): add cli-arg 'enable-esm'

* test(cucumber-runner): add tests for enable esm options/cli arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityvi gravityvi gravityvi approved these changes

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightwatch force importing cucumber files in CJS even if Cucumber is configured to use ESM
4 participants
@thermsdorff @CLAassistant @gravityvi @AutomatedTester