Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move execute and executeAsync to document ns. #3807

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Move execute and executeAsync to document ns. #3807

merged 2 commits into from
Jul 17, 2023

Conversation

garg3133
Copy link
Member

This PR migrates execute and executeAsync commands from lib/api/protocol to lib/api/client-commands, while also making them available on .document namespace.

@github-actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

gravityvi
gravityvi approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@gravityvi gravityvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@beatfactor beatfactor merged commit b92b63f into nightwatchjs:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityvi gravityvi gravityvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garg3133 @gravityvi @beatfactor