Update jsdom to v21.1.2 and npm audit fix. #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
itsspriyansh
changed the title
…h/nightwatch into updated-dependencies
garg3133
changed the title
garg3133
approved these changes
Jul 17, 2023
swrdfish
approved these changes
Jul 17, 2023
itsspriyansh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why jsdom is updated?
There were two dependency vulnerabilities,
w3c-hr-timeandtough-cookie, which are dependent on the dependencyjsdomhence in order to fix this issuejsdomupgrade was considered.Why jsdom is updated to v21.1.2?
v21.1.2 is the highest version that won't lead to any breaking change. Updating further, Node.js v16 will be the minimum supported version.
Why npm audit fix is run?
In order to fix the vulnerability
word-wrapwhich was of moderate severity,npm audit fixcommand was run.