Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error handling for worker threads #3828

Merged
merged 3 commits into from
Jul 26, 2023
Merged

add error handling for worker threads #3828

merged 3 commits into from
Jul 26, 2023

Conversation

gravityvi
Copy link
Member

@gravityvi gravityvi commented Jul 21, 2023 •
edited
Loading

@github-actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@gravityvi gravityvi marked this pull request as ready for review July 25, 2023 08:49
@gravityvi gravityvi requested review from beatfactor and garg3133 July 25, 2023 08:49
@AutomatedTester AutomatedTester requested a review from swrdfish July 25, 2023 10:25
@gravityvi gravityvi mentioned this pull request Jul 25, 2023
Closed
beatfactor
beatfactor approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@beatfactor beatfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@gravityvi gravityvi merged commit fcb9dd8 into nightwatchjs:main Jul 26, 2023
@gravityvi gravityvi mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrdfish swrdfish swrdfish approved these changes

@beatfactor beatfactor beatfactor approved these changes

@garg3133 garg3133 Awaiting requested review from garg3133

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gravityvi @beatfactor @swrdfish