Fix error while exiting Nightwatch using Ctrl+C. #4013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if we try to exit Nightwatch by pressing
Ctrl+C
, we get anuncaughtException
error. This happens because starting with Node 16, a signal ofstring
type (i.e.SIGINT
) is emitted on pressingCtrl+C
instead ofnumber
type, butprocess.exit()
still accepts a code ofnumber
type as the first argument.This PR fixes this by always exiting the process with code
0
in case aSIGINT
signal is encountered. (In Node 14 also, the process used to exit with code0
upon pressingCtrl+C
.)