issue #4028 fix : added fallback for clearValue command

[FireNdIce3]

Add a fallback for clearValue command where Nightwatch will now try to delete the text in an input field by sending backspaces if the text is not deleted by the clear command directly.

This fallback will also work for commands like setValue, updateValue, etc. which clears the text before entering new text.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Status

• ✅ Type files updated!

[garg3133]

We'd also need to have some unit tests written for this PR. You can try to explore how the tests are written in Nightwatch and ask if you don't understand anything or need any help.

[FireNdIce3]

We'd also need to have some unit tests written for this PR. You can try to explore how the tests are written in Nightwatch and ask if you don't understand anything or need any help.

Can you please guide me where to explore regarding writing tests?
Thanks

[FireNdIce3]

I am confused why they are not strictly equal
Can you please help with this?

[garg3133]

I am confused why they are not strictly equal
Can you please help with this?

Two arrays are never strictly equal (being strictly equal would mean that both refer to the same memory location). Use can use deepStrictEqual instead.

[FireNdIce3]

I looked through the verbose logs and indeed keys are going in an array
But I am still unsure what's wrong with the test
is there any Doc i can refer for this?

[FireNdIce3]

hi the tests are working fine as of now.. is there anything that's left?
thanks

[FireNdIce3]

@garg3133 the linting issues has been fixed
apologies fixing linting issues.. thankyou for being patient

[garg3133]

@FireNdIce3 Can you remove the formatting changes you've made in the test file? Your PR should not contain any changes that are not related to the issue at hand, it makes it really difficult to review the PR.

[garg3133]

The test is still not right (it isn't actually testing anything). A good way to see if tests are doing anything or not is to revert back your code changes and see if the test is failing. If the test is still passing then that means that the test is actually not testing what you meant to test, i.e., not doing anything.

In the test you've written, when you run it you can see in the logs that the last response is 404.

The motive of writing this test is to make sure that the .getProperty('value') command is being run and after that .sendKeys() is also being run. But to test if these commands are actually executed, we'd somehow need to check if the mocks defined by us are being used.

We can do that by adding a onRequest() method in mock. So, what we'll do is something along the lines of following:

      const bArr = Array(6).fill(Key.BACK_SPACE);
      const str = bArr.join('');
      
      let sendKeysMockCalled = false;

      MockServer.addMock(
        {
          url: '/session/13521-10219-202/element/5cc459b8-36a8-3042-8b4a-258883ea642b/clear',
          response: {value: 'sample'}
        },
        true
      );

      MockServer.addMock({
          url: '/session/13521-10219-202/element/5cc459b8-36a8-3042-8b4a-258883ea642b/value',
          method: 'POST',
          postdata: {
            str,
            value: bArr
          },
          onRequest() {
            sendKeysMockCalled = true;
          },
          response: {
            value: null
          },
          statusCode: 200
        }, true);

      client.api.clearValue('#webdriver', function (result) {
        assert.strictEqual(result.value, null);
        assert.strictEqual(sendKeysMockCalled, true);
        // ensures fallback is working
      });

      client.start(done);

The above test will make sure that the .sendKeys() command is actually called, which is the purpose of having this test.

[FireNdIce3]

@garg3133 sorry for that..
will do the required changes

[garg3133]

No need to be sorry. Are you looking into some other issues as well?

[FireNdIce3]

@garg3133 yes, I am looking into the issues you mentioned to work upon. currently exploring the codebase and investigating the cause.

[FireNdIce3]

hi @garg3133
I have updated the test and its passing
Can you please review again when you get the time
Thanks

[garg3133]

Why are you calling .sendKeys() command directly? We just want to call .clearValue command from outside and then we want to test if the internal element.sendKeys() (which you specified in method-mappings.js file) was called or not if the element.getProperty('value') command still returns some value.

[FireNdIce3]

Hi @garg3133 ,
for some reason, the post request was not being sent when I tried checking the logs
So I looked into the codebase to see how keys were being sent in a test and I saw this method
I tried doing it by using .sendKeys() and it worked

[uditrajput03]

Hi @garg3133 , for some reason, the post request was not being sent when I tried checking the logs So I looked into the codebase to see how keys were being sent in a test and I saw this method I tried doing it by using .sendKeys() and it worked

Are you still working on this issue ?

[FireNdIce3]

yes I am working on this. had been sick that's why the delay
apologies

[fanfanj42]

Hi, just wanted to make sure that this is all still being worked on. I could land an eye if you need. (not sure that I can be of a great help but I can still try 😬)

[github-actions]

Status

• ❌ No modified files found in the types directory.
  Please make sure to include types for any changes you have made. Thank you!.