-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actionable error message for TimeoutError
in hooks.
#4053
Add actionable error message for TimeoutError
in hooks.
#4053
Conversation
output: @garg3133 this is ready for review |
Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One suggestion: While writing the commit messages, try to use the imperative style of writing: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?h=v2.36.1#n181 |
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Thanks @garg3133 will keep that in mind for future commits. |
TimeoutError
in hooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AutomatedTester This is ready to be merged.
Congrats @dikwickley on your first PR merge in the project 🎉 |
fixes: #4031
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-feature
orissue/123-my-bugfix
);