-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added isDisplayed()
as alias to isVisible()
#4107
Merged
AutomatedTester
merged 4 commits into
nightwatchjs:main
from
uditrajput03:issue/4105-isDispalyed-as-alias
Mar 13, 2024
Merged
Added isDisplayed()
as alias to isVisible()
#4107
AutomatedTester
merged 4 commits into
nightwatchjs:main
from
uditrajput03:issue/4105-isDispalyed-as-alias
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@garg3133 would you mind reviewing my PR |
uditrajput03
changed the title
Added isDisplayed as alias to isVisible
Added isDisplayed() as alias to isVisible()
Mar 8, 2024
uditrajput03
changed the title
Added isDisplayed() as alias to isVisible()
Added Mar 8, 2024
isDisplayed()
as alias to isVisible()
@uditrajput03 The PR looks good, thanks! For tests, the top two test cases are sufficient. You can remove the rest. |
This was referenced Mar 9, 2024
8 tasks
Sure, Earlier I also think that. |
This was referenced Mar 9, 2024
garg3133
approved these changes
Mar 9, 2024
vaibhavsingh97
approved these changes
Mar 13, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4105
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-feature
orissue/123-my-bugfix
);