Save command result values in Json Report. #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
…ctree and logged. Also fixes a bug where the nodes from new Element API were getting resolved early due to which the following Nightwatch commands were getting added as child nodes of the last new Element API command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the result values for the Nightwatch commands are not saved in the JSON report, only the result status is saved.
This PR allows users to save the command result values as well in the JSON report by setting the
save_command_result_valueconfig totruein the Nightwatch configuration file.For large result values, a new file is created to put the result value and the path of that file is saved in the JSON report instead of the actual value.
cc: @sauravdas1997