Add isActive() command to new Element API

[dikwickley]

This PR adds a new isActive() command to the new Element API
Fixes: dikwickley/gsoc24#6

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

• Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
• Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
• If you're fixing a bug also create an issue if one doesn't exist yet;
• If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
• Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
• If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
• Do not include changes that are not related to the issue at hand;
• Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
• Always add unit tests - PRs without tests are most of the times ignored.

[github-actions]

Status

• ✅ Type files updated!

[garg3133]

Shouldn't we use this endpoint to get the active element?

[dikwickley]

this actually returns the active element, so we won't be able to get the element here to check if the element is that element only.

[garg3133]

Can we add just a few basic tests here, similar to done in other commands?

[dikwickley]

@garg3133 added some tests.

[garg3133]

@dikwickley I just found out that we in fact already have the implementations for the computedrole and computedlabel under the command names of getAriaRole and getAccessibleName. So, instead of creating a new command for these two, we just need to add aliases in the existing commands (along with added test cases in the existing test files and types).

Also, for the isActive command, it would be better to use the endpoint itself (following the standards). I see a method already present in the method-mappings file for getting the active element, we could use that method inside the isElementActive method to get the element id of the currently active element and then compare it with the id of the element passed. Also, the isActive command would also require some basic tests.

[garg3133]

@dikwickley Any updates here?

[dikwickley]

@garg3133 i will add the new aliases and will send in the code for isActive soon.