Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomCommandInstance interface for this in custom commands. #4310

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

garg3133
Copy link
Member

An appliable type for this was missing while writing class-styled custom commands. This PR fixes that by adding a new CommandInstance interface that could be used while writing custom commands for this (as shown in the types/tests/customCommands.test-d.ts` file).

@garg3133 garg3133 changed the title Add types for this in custom commands. Add CustomCommandInstance interface for this in custom commands. Nov 25, 2024
@garg3133 garg3133 merged commit 35d2e7d into nightwatchjs:main Nov 25, 2024
15 of 17 checks passed
@garg3133 garg3133 deleted the add-this-type-custom-commands branch November 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant