Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.11] LIBZIP_VERSION_MICRO empty breaks build #455

Closed
remicollet opened this issue Sep 19, 2024 · 0 comments
Closed

[1.11] LIBZIP_VERSION_MICRO empty breaks build #455

remicollet opened this issue Sep 19, 2024 · 0 comments
Labels
bug libzip doesn't behave as expected.

Comments

@remicollet
Copy link
Contributor

remicollet commented Sep 19, 2024

Can you please publish release as 1.11.0 so LIBZIP_VERSION_MICRO is not empty

Having an empty macro breaks builds, ex PHP

See https://github.com/php/php-src/blob/master/ext/zip/php_zip.h#L96

/work/GIT/pecl-and-ext/zip/php81/php_zip.h:96:135: error: operator '+' has no right operand
   96 | #define LIBZIP_ATLEAST(m,n,p) ((m<<16) + (n<<8) + p) <= ((LIBZIP_VERSION_MAJOR<<16) + (LIBZIP_VERSION_MINOR<<8) + LIBZIP_VERSION_MICRO))
      |                                                                                                                                       ^

@remicollet remicollet added the bug libzip doesn't behave as expected. label Sep 19, 2024
@nih-at nih-at deleted a comment Sep 19, 2024
@remicollet remicollet mentioned this issue Sep 19, 2024
@dillof dillof closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug libzip doesn't behave as expected.
Projects
None yet
Development

No branches or pull requests

2 participants