Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geographic location update and correction of typos for AWS tutorial #248

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

josesanchez1815
Copy link
Contributor

@josesanchez1815 josesanchez1815 commented Oct 14, 2020

Updated directions about the geographic location portion line 23.
Updated a typo utilise to utilize.

PR Checklist

PR Description

Briefly describe the changes this PR will add/address
Preview link
Add the RTD auto generated preview link

Review format

Can someone double check my changes? Its an update to the directions and fixing of typos

Timeline

Anytime before we merge dev to stable.

Updated directions about the geographic location portion line 23.
Updated a typo utilise to utilize.
@josesanchez1815 josesanchez1815 added the fixes Label for PR merges related to fixes label Oct 14, 2020
@josesanchez1815 josesanchez1815 requested review from s-canchi and removed request for jeremywalter October 14, 2020 23:12
@github-actions
Copy link

Reviewer Checklist
- [ ] spelling and grammar
- [ ] successful run of all installation and code chunks
- [ ] sufficient explanation and details for the tutorial content
- [ ] code syntax and naming convention
- [ ] adherence of tutorial format to style guide
- [ ] functional links (inter and intra)
- [ ] accessible hyperlink text

@marisalim
Copy link
Contributor

marisalim commented Oct 15, 2020

@josesanchez1815 changes look fine, but could you add how users choose the location? i.e., should they choose location nearest to them?

https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-plan-region.html

Copy link
Contributor

@s-canchi s-canchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I added an admonition box for the AWS region info.

@s-canchi s-canchi added the Oct-2020 Website release for October 2020 label Oct 15, 2020
Copy link
Contributor

@marisalim marisalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@josesanchez1815 josesanchez1815 merged commit 400ec64 into dev Oct 15, 2020
@josesanchez1815 josesanchez1815 deleted the josesanchez1815-patch-1 branch October 15, 2020 16:56
@s-canchi s-canchi changed the title Geographic location update and typos Geographic location update and correction of typos for AWS tutorial Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Label for PR merges related to fixes Oct-2020 Website release for October 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants