Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to KF portal tutorials: screenshots and text #291

Merged
merged 16 commits into from
Dec 18, 2020

Conversation

s-canchi
Copy link
Contributor

@s-canchi s-canchi commented Dec 15, 2020

PR Checklist

PR Description

Updated to screenshots and minor text additions to reflect the latest numbers and look of KF DRC Portal.
Preview link
https://cfde-training-and-engagement--291.com.readthedocs.build/en/291/

Review format

comments and/or direct edits

Timeline

merge for Dec2020 release

@s-canchi s-canchi added Dec-2020 Website release for December 2020 fixes Label for PR merges related to fixes labels Dec 15, 2020
@github-actions
Copy link

Reviewer Checklist
- [ ] spelling and grammar
- [ ] successful run of all installation and code chunks
- [ ] sufficient explanation and details for the tutorial content
- [ ] code syntax and naming convention
- [ ] adherence of tutorial format to style guide
- [ ] functional links (inter and intra)
- [ ] accessible hyperlink text

@s-canchi s-canchi linked an issue Dec 15, 2020 that may be closed by this pull request
@s-canchi
Copy link
Contributor Author

s-canchi commented Dec 15, 2020

  • I will be fixing the screenshots in Joint Queries and Checking Queries by end of 15th.

@abhijna
Copy link
Collaborator

abhijna commented Dec 17, 2020

@s-canchi in your new screenshots all the arrows are purple vs. the red in all my screenshots. But I'm sure it's not a big deal, but letting you know since you like consistency :D

@marisalim
Copy link
Contributor

This PR looks good to me, but let's leave it open for another day in case there are more updates after the workshop :)

@s-canchi
Copy link
Contributor Author

Thank you @abhijna ! I didn't notice the shade difference but was trying to match the KF portal colors. We can update for the next iteration 👍

@marisalim - I agree and will have it open till tomorrow for any final changes or edits we would like to include.

Copy link
Contributor

@marisalim marisalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@s-canchi s-canchi merged commit c1e8048 into dev Dec 18, 2020
@s-canchi s-canchi deleted the scanchi-kfportal-fixes branch December 18, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dec-2020 Website release for December 2020 fixes Label for PR merges related to fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to KF tutorial based on latest Portal UI
3 participants