Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda edits for JOSE paper #475

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conda edits for JOSE paper #475

merged 2 commits into from
Nov 18, 2021

Conversation

marisalim
Copy link
Contributor

@marisalim marisalim commented Nov 15, 2021

PR Checklist

  • Release label added - when is the next release?
  • PR category label added
  • PR mergeable
  • Clean build logs - nearly, broken github action for the reviewer checklist?
  • Linked related issues
  • Colorblindness test https://www.toptal.com/designers/colorfilter/ - n/a

PR Description

per suggestions from Dirk's JOSE review #472 , #473

  • added --from-history export as a note in the Method 3 yaml section
  • added some more context for the vidlets

Preview link
https://cfde-training-and-engagement--475.com.readthedocs.build/en/475/General-Tools/Introduction-to-Conda/conda2/

Review format

comments or direct edits

Timeline

aiming for before Thanksgiving, or sooner 🦃

per suggestions from Dirk's JOSE review
Copy link
Contributor

@s-canchi s-canchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the videos, would it also make sense to list few big steps as bullet points ? The goal of the video is summarized in a sentence but it can be challenging to follow through without additional written text or narration. Adding CC files for specific timestamps would also be awesome but would vary in format from rest of the website.

@marisalim
Copy link
Contributor Author

For the videos, would it also make sense to list few big steps as bullet points ? The goal of the video is summarized in a sentence but it can be challenging to follow through without additional written text or narration. Adding CC files for specific timestamps would also be awesome but would vary in format from rest of the website.

all the code steps for the videos are right next to the vidlets (either directly above or below).

Copy link
Contributor

@s-canchi s-canchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marisalim marisalim merged commit 33e7d8e into dev Nov 18, 2021
@marisalim marisalim deleted the marisa-conda-edits branch November 18, 2021 20:58
@s-canchi s-canchi added the Training-Release Label for PRs to be included in release notes label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Label for PR merges related to fixes Training-Release Label for PRs to be included in release notes TrainingSite
Projects
None yet
2 participants